Skip to content

[skip changelog] Correct format of upload_port identification properties in snippet #2655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 28, 2024
Merged

[skip changelog] Correct format of upload_port identification properties in snippet #2655

merged 1 commit into from
Jun 28, 2024

Conversation

per1234
Copy link
Contributor

@per1234 per1234 commented Jun 28, 2024

Please check if the PR fulfills these requirements

See how to contribute

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • [NA] Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • [NA] UPGRADING.md has been updated with a migration guide (for breaking changes)
  • [NA] configuration.schema.json updated if new parameters are added.

What kind of change does this PR introduce?

Docs fix

What is the current behavior?

The platform developer can associate port properties with a board definition in order to cause Arduino CLI to identify ports having those properties as that board.

The list format is supported for these platform properties in order to allow multiple alternative sets of port properties to be associated with a board definition. The platform property must have the format upload_port.n.<property ID> (where n is the array index of the port properties set).

Although the platform property format is correctly documented in the Arduino Platform Specification, an incorrect format upload_port.<property ID>.n was previously used in the boards.txt snippet illustrating the use of the platform properties.

What is the new behavior?

The snippet uses the correct property format.

Does this PR introduce a breaking change, and is titled accordingly?

No breaking change.

…rties in snippet

The platform developer can associate port properties with a board definition in order to cause Arduino CLI to identify
ports having those properties as that board.

The list format is supported for these platform properties in order to allow multiple alternative port property sets to
be associated. The platform property must have the format `upload_port.n.<property ID>` (where "n" is the array index of
the port property set).

Although the platform property format is correctly documented in the Arduino Platform Specification, an incorrect format
`upload_port.<property ID>.n` was previously used in the boards.txt snippet illustrating the use of the platform
properties.
@per1234 per1234 added topic: documentation Related to documentation for the project type: imperfection Perceived defect in any part of project labels Jun 28, 2024
@per1234 per1234 requested a review from alessio-perugini June 28, 2024 04:52
@per1234 per1234 self-assigned this Jun 28, 2024
Copy link
Contributor

@alessio-perugini alessio-perugini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@per1234 per1234 merged commit 7a4f716 into arduino:master Jun 28, 2024
6 checks passed
@per1234 per1234 deleted the correct-identification-properties branch June 28, 2024 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: documentation Related to documentation for the project type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants